This repository has been archived by the owner on Sep 10, 2023. It is now read-only.
Update to quap to Turings MAP
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually use MAP if I'm saying I use MAP. Variable `MAP` had to be renamed to avoid conflict
|
I just noticed that adding start values for the optimization errors: |
|
Nice catch! No doubt will be fixed soon! Shall we merge or hold off until this is fixed? |
|
I don't think I have an opinion on this. It's not really used anywhere right now (except by me internally) so I don't think it makes much of a difference. |
|
Ok, I’ll merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned before, with Turings new capabilities things get much easier. We don't have to find a starting point and adding return statements to the model is not necessary.
I'm not sure if making a difference between the 1D case and the rest makes sense, it's just a little more convenient because it allows
rand(distr, 10)to return aVectorthen. But then again, 1D isn't really that special.I was thinking about adding a
QuApResulttype so we can have convenientrand(result),precis(result)(or what else have you) functions.