This repository has been archived by the owner on Sep 10, 2023. It is now read-only.
Switch to Franklin #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@goedman Apologies for merging this myself without review! I wanted to squash my commits into master on my own fork and messed it up! I guess this is what it is now because fixing a Git history is terrible. Let me know if you want me to revert the changes.
Noteworthy changes which you might want to review are
Furthermore, note that the site still contains a few dozen mistakes, inconsistencies and even some errors. I've fixed some of them, but quickly realized that it would take at least a week. Overall, I do think that these changes are an improvement, and I plan to fix the issues over time, so that is why I decided to merge now.