-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to System.CommandLine #234
base: master
Are you sure you want to change the base?
Conversation
The general standardization here seems fine. I will double check and make sure specifying multiple --depots (and now --os as well) works reasonably. |
2d0fd53
to
22674a5
Compare
Since this PR already adds extra array support to some options, #221 could be handled as well. |
22674a5
to
209d838
Compare
209d838
to
d6d3513
Compare
d6d3513
to
ce5c986
Compare
Tried this branch but I'm getting
Files were successfully downloaded unlike the message says 0 bytes. Full log with |
Are there any remaining issues with this PR? |
# Conflicts: # DepotDownloader/ContentDownloader.cs # DepotDownloader/DepotDownloader.csproj # DepotDownloader/Program.cs
That should be fixed by |
Worked nicely! Only downside is that the downloaded files goes to the same directory now mixing content of both IDs ( |
Currently input handling is really... unconventional, this PR uses the commandline parser library to make input more standardized (and flexible).
Closes #86, closes #88, closes #221