Config Server Data dictionary not cleared before Load #185
Conversation
[#184] The Config Server's Data dicitonary needs to be cleared before loading it
|
|
Codecov Report
@@ Coverage Diff @@
## 2.x #185 +/- ##
==========================================
- Coverage 61.74% 61.71% -0.03%
==========================================
Files 784 784
Lines 22557 22558 +1
Branches 4389 4389
==========================================
- Hits 13928 13922 -6
- Misses 7438 7452 +14
+ Partials 1191 1184 -7
Continue to review full report at Codecov.
|
| @@ -264,6 +264,8 @@ internal ConfigEnvironment DoLoad(bool updateDictionary = true) | |||
| "Located environment: {name}, {profiles}, {label}, {version}, {state}", env.Name, env.Profiles, env.Label, env.Version, env.State); | |||
| if (updateDictionary) | |||
| { | |||
| Data.Clear(); | |||
There was a problem hiding this comment.
@dtillman I won't add this one here, this could impact requests which are currently reading the dictinoary value. I would add another local temp dictonary and add the new values init and replace with existing one .
There was a problem hiding this comment.
Ahh .. great point .. thanks!
Dave
|
No worries, @vivekkjain. We always merge the 2.x branch forward to master (3.x branch). Thanks for opening the issue and the review. |
TimHess
added
ReleaseLine/2.x
[#184] The Config Server's Data dicitonary needs to be cleared before loading it