[core] Allow reuse of cluster address if Ray is not running (ray-proj…

…ect#27666) Signed-off-by: Stephanie Wang [email protected] Cluster address is now written to a temp file. Previously we raised an error if ray start --head tried to reuse the old cluster address in the temp file, even if Ray was no longer running. This PR allows ray start --head to continue if it can't find any GCS process associated with the recorded cluster address. Related issue number Closes ray-project#27021. Signed-off-by: Stefan van der Kleij <[email protected]>
Stefan-1313 · Aug 18, 2022 · 5f15cf2 · 5f15cf2
1 parent 7b7a610
commit 5f15cf2
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/python/ray/scripts/scripts.py b/python/ray/scripts/scripts.py
@@ -730,7 +730,12 @@ def start(
         if address is None:
             default_address = f"{ray_params.node_ip_address}:{port}"
             bootstrap_address = services.find_bootstrap_address(temp_dir)
-            if default_address == bootstrap_address:
+            if (
+                default_address == bootstrap_address
+                and bootstrap_address in services.find_gcs_addresses()
+            ):
+                # The default address is already in use by a local running GCS
+                # instance.
                 raise ConnectionError(
                     f"Ray is trying to start at {default_address}, "
                     f"but is already running at {bootstrap_address}. "

diff --git a/python/ray/tests/test_cli.py b/python/ray/tests/test_cli.py
@@ -292,6 +292,7 @@ def test_ray_start(configure_lang, monkeypatch, tmp_path):
     # Check that --temp-dir arg worked:
     assert os.path.isfile(os.path.join(temp_dir, "ray_current_cluster"))
     assert os.path.isdir(os.path.join(temp_dir, "session_latest"))
+    _die_on_error(result)
 
     _die_on_error(runner.invoke(scripts.stop))
 
@@ -300,6 +301,24 @@ def test_ray_start(configure_lang, monkeypatch, tmp_path):
     else:
         _check_output_via_pattern("test_ray_start.txt", result)
 
+    # Check that we can rerun `ray start` even though the cluster address file
+    # is already written.
+    _die_on_error(
+        runner.invoke(
+            scripts.start,
+            [
+                "--head",
+                "--log-style=pretty",
+                "--log-color",
+                "False",
+                "--port",
+                "0",
+                "--temp-dir",
+                temp_dir,
+            ],
+        )
+    )
+
 
 def _ray_start_hook(ray_params, head):
     os.makedirs(ray_params.temp_dir, exist_ok=True)