Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unlocked byte I/O operations #5

Merged
merged 2 commits into from
Mar 24, 2020
Merged

use unlocked byte I/O operations #5

merged 2 commits into from
Mar 24, 2020

Conversation

StefanKarpinski
Copy link
Owner

@StefanKarpinski StefanKarpinski commented Mar 24, 2020

That last one didn't really work.

@StefanKarpinski StefanKarpinski merged commit 62e2a2d into master Mar 24, 2020
@StefanKarpinski StefanKarpinski deleted the sk/unlocked branch March 24, 2020 01:46
@giordano
Copy link

I think on Windows they're called _getc_nolock, _putc_nolock, etc?

@StefanKarpinski
Copy link
Owner Author

Ah, ok. That's helpful. This looked like it was succeeding but then failed. Now I have all these bogus releases 😞. Might have to blow the repo away and recreate it without all the detritus.

@StefanKarpinski
Copy link
Owner Author

How do I detect if I'm compiling for Windows or not in the BB build environment?

@giordano
Copy link

In BB you can check the target environment variable. For example, in bash

if [[  "${target}" == *-mingw* ]]; then
    # ...
fi

In a Makefile outside BB it's a bit more convoluted. I've based JuliaStrings/utf8proc#174 on what Julia does to detect Windows, as suggested by Keno.

StefanKarpinski added a commit that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants