Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the experience of using muxed account. #311

Merged
merged 5 commits into from
May 3, 2020
Merged

Conversation

overcat
Copy link
Member

@overcat overcat commented May 1, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #311 into dev will increase coverage by 0.00%.
The diff coverage is 99.19%.

Impacted file tree graph

@@           Coverage Diff            @@
##              dev     #311    +/-   ##
========================================
  Coverage   99.06%   99.07%            
========================================
  Files         114      116     +2     
  Lines        5220     5485   +265     
========================================
+ Hits         5171     5434   +263     
- Misses         49       51     +2     
Flag Coverage Δ
#unittests 99.07% <99.19%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
stellar_sdk/helpers.py 100.00% <ø> (ø)
stellar_sdk/sep/stellar_web_authentication.py 95.74% <ø> (ø)
stellar_sdk/fee_bump_transaction.py 97.05% <83.33%> (+0.28%) ⬆️
stellar_sdk/muxed_account.py 96.07% <96.07%> (ø)
stellar_sdk/__init__.py 100.00% <100.00%> (ø)
stellar_sdk/account.py 100.00% <100.00%> (ø)
stellar_sdk/operation/account_merge.py 100.00% <100.00%> (ø)
stellar_sdk/operation/allow_trust.py 100.00% <100.00%> (ø)
stellar_sdk/operation/bump_sequence.py 100.00% <100.00%> (ø)
stellar_sdk/operation/change_trust.py 100.00% <100.00%> (ø)
... and 26 more

__all__ = ["MuxedAccount"]


class MuxedAccount:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abuiles, do you think it is worth adding the MuxedAccount class to js-stellar-base? I would love to hear your opinion.

@overcat overcat marked this pull request as ready for review May 3, 2020 01:21
@overcat overcat merged commit 8ed9f0f into dev May 3, 2020
@overcat overcat deleted the dev-muxed-account branch June 18, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant