Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Optimize the use of stellar_sdk.client.AiohttpClient. #317

Merged
merged 5 commits into from
May 17, 2020

Conversation

overcat
Copy link
Member

@overcat overcat commented May 16, 2020

When stellar_sdk.client.AiohttpClient cannot establish a Stream connection, stellar_sdk.exceptions.StreamClientError will be thrown.

When `stellar_sdk.client.AiohttpClient` cannot establish a Stream connection, `stellar_sdk.exceptions.StreamClientError` will be thrown.
@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #317 into dev will decrease coverage by 0.12%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #317      +/-   ##
==========================================
- Coverage   99.05%   98.93%   -0.13%     
==========================================
  Files         116      117       +1     
  Lines        5524     5611      +87     
==========================================
+ Hits         5472     5551      +79     
- Misses         52       60       +8     
Flag Coverage Δ
#unittests 98.93% <38.46%> (-0.13%) ⬇️
Impacted Files Coverage Δ
stellar_sdk/call_builder/base_call_builder.py 100.00% <ø> (ø)
stellar_sdk/client/aiohttp_client.py 85.34% <33.33%> (-2.33%) ⬇️
stellar_sdk/exceptions.py 90.32% <50.00%> (-2.79%) ⬇️
stellar_sdk/client/defines.py 100.00% <0.00%> (ø)
stellar_sdk/client/requests_client.py 98.29% <0.00%> (+3.29%) ⬆️

@overcat overcat merged commit a846dde into dev May 17, 2020
@overcat overcat deleted the dev-sse-async branch June 18, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant