Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Protocol 14 #367

Merged
merged 8 commits into from
Oct 2, 2020
Merged

feat: add support for Protocol 14 #367

merged 8 commits into from
Oct 2, 2020

Conversation

overcat
Copy link
Member

@overcat overcat commented Sep 19, 2020

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #367 into dev will increase coverage by 0.03%.
The diff coverage is 99.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #367      +/-   ##
==========================================
+ Coverage   98.95%   98.99%   +0.03%     
==========================================
  Files         119      127       +8     
  Lines        6817     7570     +753     
==========================================
+ Hits         6746     7494     +748     
- Misses         71       76       +5     
Flag Coverage Δ
#unittests 98.99% <99.22%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stellar_sdk/signer_key.py 91.42% <91.42%> (ø)
stellar_sdk/operation/revoke_sponsorship.py 98.35% <98.35%> (ø)
stellar_sdk/__init__.py 100.00% <100.00%> (ø)
stellar_sdk/__version__.py 100.00% <100.00%> (ø)
stellar_sdk/call_builder/__init__.py 100.00% <100.00%> (ø)
stellar_sdk/call_builder/accounts_call_builder.py 100.00% <100.00%> (ø)
...dk/call_builder/claimable_balances_call_builder.py 100.00% <100.00%> (ø)
stellar_sdk/call_builder/offers_call_builder.py 90.62% <100.00%> (+0.96%) ⬆️
stellar_sdk/operation/__init__.py 100.00% <100.00%> (ø)
..._sdk/operation/begin_sponsoring_future_reserves.py 100.00% <100.00%> (ø)
... and 21 more

@JakeUrban
Copy link
Contributor

Do we have an estimation on when P14 changes will be released?

@overcat
Copy link
Member Author

overcat commented Sep 29, 2020 via email

@overcat overcat changed the title feat: add support for protocal 14 feat: add support for Protocol 14 Oct 1, 2020
@overcat overcat marked this pull request as ready for review October 2, 2020 02:50
@overcat overcat merged commit df2adfc into dev Oct 2, 2020
@overcat overcat deleted the dev-protocol-14 branch October 4, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants