Remove property filter as string to promote expressions

[ogizanagi]

I suggest to remove this syntax:

$users = $contentManager->getContents(User::class, null, 'active');

in favor of expressions:

$users = $contentManager->getContents(User::class, null, '_.active');

since:

• it's not much more complex to write

• it allows to enable first-class support for expressions as filters, removing the need to create an Expression instance with expr/ exprOr, and expressions are way more powerful:

  -$users = $contentManager->getContents(User::class, null, expr('_.active'));
  +$users = $contentManager->getContents(User::class, null, '_.active');

• we do not seem to use this syntax since the begining, but rather use:

  $users = $contentManager->getContents(User::class, null, ['active' => true]);

WDYT?

[Tom32i]

Ok with me! Technically it's a BC break right?

[ogizanagi]

True, as in the latest releases, we'll add a small note:

Breaking Changes ⚠️

The ContentManager::getContents() method now accepts string based expressions as filter.
As a consequence, the ability to use a property name as filter directly as a string was removed. Use an expression instead:

-$users = $contentManager->getContents(User::class, null, 'active');
+$users = $contentManager->getContents(User::class, null, '_.active');