Warn user about HTTP No-Index headers #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to test this. |
ogizanagi
approved these changes
Jul 15, 2021
| @@ -396,6 +397,12 @@ private function buildUrl(string $url, bool $ignoreContentNotFoundErrors = false | |||
| $output = ob_get_clean(); | |||
| $content = $response->getContent() ?: $output; | |||
|
|
|||
| if ($this->hasNoIndexHeader($response) && !$this->hasNoIndexTag($content)) { | |||
| $this->logger->warning('Url "{url}" contains a "x-robots-tag: noindex" header that will be lost by going static. Consider using the HTML tag "<meta name="robots" content="noindex" />" instead.', [ | |||
There was a problem hiding this comment.
Since the progress bar (used in normal verbosity and interactive mode) may "eat" the first logs by redrawing over, the user might miss the warnings if there are only a few of them.
Note this is not an issue in CI (non-interactive), or whenever using another verbosity level (-v is enough). But I've 1 or 2 idea(s) for gathering such warnings to be displayed at the end of the command execution with the progress bar.
Co-authored-by: Maxime Steinhausser <[email protected]>
Tom32i
commented
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #65