Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra body tags from processed contents #165

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

ogizanagi
Copy link
Member

Fixes #164

Copy link
Collaborator

@Tom32i Tom32i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks :)

@@ -20,7 +20,7 @@ interface HtmlCrawlerManagerInterface
/**
* Get HTML Crawler for the given property (creates it if needed)
*/
public function get(Content $content, array &$data, string $property): ?Crawler;
public function get(Content $content, array $data, string $property): ?Crawler;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Micro BC-break I guess, but seems fair.

@ogizanagi ogizanagi merged commit 885a066 into master Feb 2, 2023
@ogizanagi ogizanagi deleted the fix-extra-body branch February 2, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra body tag added by crawler
2 participants