Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

大佬啊 分下文件啦 一个文件1000+行太可怕了 #25

Open
wztscau opened this issue Jul 14, 2021 · 3 comments
Open

大佬啊 分下文件啦 一个文件1000+行太可怕了 #25

wztscau opened this issue Jul 14, 2021 · 3 comments

Comments

@wztscau
Copy link

wztscau commented Jul 14, 2021

No description provided.

@ghost
Copy link

ghost commented Jul 17, 2021

分不分无所谓的啦😂个人感觉没这个必要吧

@StepfenShawn
Copy link
Owner

我觉得宜家代码仲唔算多，所以用一个文件方便啲，因为只要复制一个文件就可以运行了，不过到时代码真係太多嘅话，会考虑分下

@nobodxbodon
Copy link
Contributor

读代码的确会吃力些，个人建议尽早拆分为好。
木兰的结构供参考：https://gitee.com/MulanRevive/mulan-rework/tree/master/%E6%9C%A8%E5%85%B0
大概看了一下最大区别也许是木兰是直接生成 python 语法树，没有定义自己的语法树模型。
如果按照如下拆分的话，也许新人看起来会更方便？

词法分析、语法分析、语法树模型、主程序和内置函数、辅助功能

@nobodxbodon nobodxbodon mentioned this issue Jul 28, 2021
Merged
nobodxbodon added a commit to nobodxbodon/Cantonese that referenced this issue Jul 29, 2021
@nobodxbodon
StepfenShawn#25 拆出词法部分, 通过基本unittest测试
9a84521
nobodxbodon added a commit to nobodxbodon/Cantonese that referenced this issue Jul 29, 2021
@nobodxbodon
StepfenShawn#25 拆出语法树节点部分
1d0ce5e
nobodxbodon added a commit to nobodxbodon/Cantonese that referenced this issue Jul 29, 2021
@nobodxbodon
StepfenShawn#25 拆出语法分析器
d1313f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nobodxbodon @wztscau @StepfenShawn