Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: let $hsv in pbr shader use alpha of $basetexture as mask #1222

Open
koteromon opened this issue Aug 12, 2024 · 2 comments
Open
Labels
Type: Enhancement This is something that improves upon an already existing thing. What: Graphics Graphics-related stuff

Comments

@koteromon
Copy link

Which component should be improved?

Render

Describe your suggestion

let $hsv in pbr shader use alpha of $basetexture as mask, the darker the alpha the less influence $hsv has on $basetexture

@koteromon koteromon added the Type: Enhancement This is something that improves upon an already existing thing. label Aug 12, 2024
@koteromon koteromon changed the title let $hsv in pbr shader use alpha of $basetexture as mask Enhancement: let $hsv in pbr shader use alpha of $basetexture as mask Aug 12, 2024
@ozxybox ozxybox transferred this issue from StrataSource/Portal-2-Community-Edition Sep 9, 2024
@JJL772
Copy link
Member

JJL772 commented Sep 9, 2024

This sounds similar to $blendtintbymraoalpha, which uses the MRAO alpha channel as a $color tint mask.

@SCell555
Copy link
Member

SCell555 commented Sep 9, 2024

$hsv_blend does already use MRAO alpha as mask.

@ozxybox ozxybox added the What: Graphics Graphics-related stuff label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This is something that improves upon an already existing thing. What: Graphics Graphics-related stuff
Projects
None yet
Development

No branches or pull requests

4 participants