Document Stream Behavior Hints For Subtitles #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBeastLT
approved these changes
Nov 28, 2023
elpiel
approved these changes
Dec 15, 2023
rleroi
approved these changes
Feb 18, 2024
rleroi
reviewed
Feb 18, 2024
| @@ -89,6 +91,12 @@ function getRouter({ manifest , get }) { | |||
|
|
|||
| res.setHeader('Content-Type', 'application/json; charset=utf-8') | |||
|
|
|||
| if (!warned.filename && resource === 'stream' && ((resp || {}).streams || []).length) | |||
There was a problem hiding this comment.
Could be a bit cleaner, e.g.
const hasStreams = !!((resp || {}).streams || []).length
const doesNotHaveFileName = resp.streams.find(stream => stream && stream.url && !(stream.behaviorHints || {}).filename)
if (!warned.filename && resource === 'stream' && hasStreams && doesNotHaveFileName) There was a problem hiding this comment.
Or a separate warnAboutEmptyFilename() function with early returns 😄
tymmesyde
reviewed
Mar 26, 2024
tymmesyde
reviewed
Mar 26, 2024
tymmesyde
reviewed
Mar 26, 2024
Co-authored-by: Tim <[email protected]>
Co-authored-by: Tim <[email protected]>
Co-authored-by: Tim <[email protected]>
dexter21767-dev
approved these changes
Mar 27, 2024
|
i think we may finally have full support across apps now for this, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.