Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release package should only contain necessary data for users #127

Open
Structed opened this issue Oct 15, 2023 · 1 comment
Open

Release package should only contain necessary data for users #127

Structed opened this issue Oct 15, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Structed
Copy link
Owner

Currently, all release packages contain pretty much all data from the repository. However, that is not necessary for the majority of users. If oner wants to get the full contents, they can clone the repository.

Steps to Reproduce

...to just install necessary files:

Scenario A

  1. Open a new project
  2. Open Asset Lib Tab
  3. Search for godot-playfab
  4. Click Download button
  5. This opens the "Install" modal

Scenario B

  1. On the GitHub Repo page, select the current release
  2. click the Source code (zip) or Source code (tar.gz) link and download the file
  3. Wait for the download to finish
  4. Open the zip/tar.gz file

Expected Behaviour

Scenario A

Only necessary addon/godot-playfab folder and an Example folder (optional) should be shown & selectable

Scenario B

Only necessary addon/godot-playfab folder and an Example folder (optional) should be in the archive

Actual Behaviour

Scenario A

All files are selected and shown. One has to deselect all files except the addons/godot-playfab folder.

Scenario B

All files are included in the archive file. You need to know which files to extract

@Structed Structed self-assigned this Oct 15, 2023
@Structed Structed added the enhancement New feature or request label Oct 15, 2023
@Structed
Copy link
Owner Author

The examples should be moved to a separate repository.

This would also allow additional examples that would need dependencies on other add-ons. E.g. an example for the Steam Login using godot-steam.

Questions

  1. Should the example project take a dependency on godot-playfab via a submodule, or just install the published project from the repo or as a submodule?
  2. Should examples that take a dependency on other add-ons take those dependencies as submodules?
  3. Should these other examples be separate repositories?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant