Restore pre-1.0.0 behavior for codepoint funs and ObjectEqualityComparator

[lppedd]

After making ObjectEqualityComparator an object, I have noticed the outputted code (and the code that's actually invoked) changed.

See the diff. Left 1.0.0-RC4 / Right 1.0.0

So in 1.0.0 a call to ObjectEqualityComparator.equals goes through:

f2s(a, b)
  y30(a, b)
   equals(a, b)

Compared to just

f2s(a, b)
  equals(a, b)

In RC4. There is also that weird:

var tmp = (a == null ? true : !(a == null)) ? a : THROW_CCE();

which I don't understand. Why would a ClassCastException be thrown there?
So I thought that it's better to revert it.

[lppedd]

This closes #198.

[ftomassetti]

I understand the equals operation being invoked on the INSTANCE field, but I am not sure about removing constants. In my opinion they made the code simpler

[ftomassetti]

To me, this seems to make the code less readable than before

[ftomassetti]

I think removing braces is good, but the constant was making the code easier to read and maintain

[lppedd]

@ftomassetti Regarding constants, I agree that keeping them as const val makes the code more readable.
My choice of manually inlining them comes from the fact an internal const val used outside of the file boundary produces additional accessors.

For example

// A.kt
internal const val MIN_LOW_SURROGATE: Int = 0xDC00

// B.kt
if (x > MIN_LOW_SURROGATE) { }

translates to

var MIN_LOW_SURROGATE = 56320;

function getMIN_LOW_SURROGATE() {
  return MIN_LOW_SURROGATE;
}

if (x > getMIN_LOW_SURROGATE()) { }

instead of

if (x > 56320) { }

It is a subjective decision, so I'm up to reverting it, but it has its benefits.

[ftomassetti]

Sorry for the late reply. Yes, I would prefer you to revert it. I see your point, but I would favor readability over the slight performance hit

[lppedd]

@ftomassetti done. I've only removed the inline modifier, so that the compiler can at least partially inline constants.

[lppedd]

You might have to manually restart the workflow.

[ftomassetti]

Thank you @lppedd jobs restarted. If they pass I will merge

[lppedd]

@ftomassetti thanks. Would it be ok to release a 1.0.1?

[ftomassetti]

@lppedd I just released 1.0.1