Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Создание простой формы регистрации #40

Merged
merged 10 commits into from
May 16, 2024

Conversation

DBratkov
Copy link
Contributor

@DBratkov DBratkov commented May 11, 2024

Создана простая форма регистрации пользователей.
В качестве заглушки используется генератор telegram_id.

Copy link
Member

@KonstantinRaikhert KonstantinRaikhert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Форма - самое то!)
2024-05-13_12-58

Добавил пару комментариев, и еще нужно посмотреть миграции, не сохранилось
2024-05-13_12-57

path('',
RegistrationCreateView.as_view(),
name='registration'),
# Временная индексная страница
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем нам времененная индексная страница сейчас?..)

import random
import sys

from .models import ApplicationForm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше абсолютные импорты.

from .models import ApplicationForm


def get_telegram_id() -> int:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Напиши еще #TODO Убрать после реализации хендлеров

from django.urls import reverse_lazy
from django.views.generic import CreateView, ListView

from .forms import RegistrationForm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Абсолютные)

Copy link
Member

@KonstantinRaikhert KonstantinRaikhert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Забираем! Чуть поправил по миграциям

@KonstantinRaikhert KonstantinRaikhert merged commit 9837ff4 into dev May 16, 2024
1 check passed
@DBratkov DBratkov deleted the feature/registration_form branch May 16, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants