Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Torrents which do not have trackers starting with http are not tagged #183

Closed
leunamd opened this issue Nov 26, 2022 · 2 comments · Fixed by #188
Closed

[Bug]: Torrents which do not have trackers starting with http are not tagged #183

leunamd opened this issue Nov 26, 2022 · 2 comments · Fixed by #188
Assignees
Labels
bug Something isn't working status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@leunamd
Copy link

leunamd commented Nov 26, 2022

Describe the Bug

From time to time it happens that I encounter torrents which only have udp protocol trackers and they do not get tagged properly, I have no problem whatsoever with other torrents which have http/https trackers.

The problem seems to be at this line.
It seems like only torrents which have atleast a tracker starting with "http" get considered, that same http check is also used for other features in that same file.

Config

commands:
  # The commands defined below will IGNORE any commands used in command line and docker env variables.
  dry_run: false
  cross_seed: false
  recheck: false
  cat_update: false
  tag_update: true
  rem_unregistered: false
  tag_tracker_error: true
  rem_orphaned: true
  tag_nohardlinks: true
  skip_cleanup: false

qbt:
  # qBittorrent parameters
  host: qbittorrent:8080

  user:
  pass:
settings:
  force_auto_tmm: true  # Will force qBittorrent to enable Automatic Torrent Management for each torrent.
  tracker_error_tag: issue  # Will set the tag of any torrents that do not have a working tracker.
  ignoreTags_OnUpdate: # When running tag-update function, it will update torrent tags for a given torrent even if the torrent has one or more of the tags defined here.
  - noHL
  - issue
  - cross-seed
directory:
  # Do not remove these
  # Cross-seed var: </your/path/here/>  # Output directory of cross-seed
  # root_dir var: </your/path/here/>  # Root downloads directory used to check for orphaned files, noHL, and RecycleBin.
  # <OPTIONAL> remote_dir var: </your/path/here/>  # Path of docker host mapping of root_dir.
  # Must be set if you're running qbit_manage locally and qBittorrent/cross_seed is in a docker
  # <OPTIONAL> recycle_bin var: </your/path/here/>   # Path of the RecycleBin folder. Default location is set to remote_dir/.RecycleBin
  # <OPTIONAL> torrents_dir var: </your/path/here/>  # Path of the your qbittorrent torrents directory. Required for `save_torrents` attribute in recyclebin

  cross_seed: /your/path/here/
  root_dir: /data/torrents/
  remote_dir: /your/path/here/
  recycle_bin: /data/torrents/.RecycleBin
  torrents_dir: /qbittorrent/data/BT_backup
  orphaned_dir: /data/torrents/orphaned_data

tracker:
  opentrackr:
    tag: public

Logs

https://gist.github.com/leunamd/e8701bd2edadccb57d6025e4be914a68

Screenshots

2022-11-26_18-42-07

Installation

Docker

Version Number

3.3.1

What branch are you on?

master

@leunamd leunamd added bug Something isn't working status:not-yet-viewed labels Nov 26, 2022
bobokun added a commit that referenced this issue Dec 3, 2022
@bobokun bobokun added status:added-to-develop Feature Request or Bug Fix is in Develop and removed status:not-yet-viewed labels Dec 3, 2022
@bobokun
Copy link
Collaborator

bobokun commented Dec 3, 2022

See #96 (comment)

@bobokun bobokun mentioned this issue Dec 3, 2022
@bobokun bobokun linked a pull request Dec 3, 2022 that will close this issue
@MrMeeb
Copy link

MrMeeb commented Dec 13, 2022

I'm not sure the change mentioned fully addresses the issue. That allows for setting a 'catchall' tag for unmentioned trackers, but it still doesn't allow us to tag based on UDP trackers - it still seems to be limited to http trackers from my testing. Unless I'm missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants