Completions: rule head (if, contains, etc) improvements #811
Labels
Comments
anderseknert
changed the title
if, contains`, etc) improvements
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this issue
Jun 13, 2024
This handles the manual trigger case better. Fixes StyraInc#811 Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this issue
Jun 13, 2024
This handles the manual trigger case better. Fixes StyraInc#811 Signed-off-by: Charlie Egan <[email protected]>
anderseknert
pushed a commit
that referenced
this issue
Jun 13, 2024
This handles the manual trigger case better. Fixes #811 Signed-off-by: Charlie Egan <[email protected]>
srenatus
pushed a commit
to srenatus/regal
that referenced
this issue
Oct 1, 2024
This handles the manual trigger case better. Fixes StyraInc#811 Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As this will be one of the more common completion suggestions, I think it's worth spending some time making it perfect.
Currently both the
ifandcontainscompletions require the user to typeiorcrespectively to show up. Since there isn't much else that can follow a rule name, we should just suggest them already after the first whitespace. This would also help people new to Rego know what's possible at that location, without having to know aboutiforcontains. On that note — we should add some docs on both of those keywords to show up in the suggestions! So that you can learn as you type.The one (?) exception is of course
:=, which we should also add a suggestion for, with an explanation that is the value returned by the rule if evaluation succeeds.The text was updated successfully, but these errors were encountered: