Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zed doesn't render markdown tables #827

Closed
anderseknert opened this issue Jun 12, 2024 · 0 comments · Fixed by #829
Closed

Zed doesn't render markdown tables #827

anderseknert opened this issue Jun 12, 2024 · 0 comments · Fixed by #829
Labels
bug Something isn't working language server protocol

Comments

@anderseknert
Copy link
Member

Yeah, this arguably not a bug in Regal, but if users of the Zed editor will have a bad Rego editing experience, that is a bug and we should do something about it.

Until the issue is fixed on their side, we should either just hide the information, or display it in some other way.

screenshot_2024-06-12_at_13 56 44_720
@anderseknert anderseknert added bug Something isn't working language server protocol labels Jun 12, 2024
anderseknert added a commit that referenced this issue Jun 12, 2024
@anderseknert
Fix markdown content rendering for Zed editor
c7b2e2e 
Since Zed doesn't render markdown tables yet, we'll just present
the arguments as a list instead. We could make an exception for Zed,
but I think I prefer having this be consistent across editors, and
the table format wasn't a requirement here.

Fixes #827

Signed-off-by: Anders Eknert <[email protected]>
anderseknert added a commit that referenced this issue Jun 12, 2024
@anderseknert
Fix markdown content rendering for Zed editor
9145101 
Since Zed doesn't render markdown tables yet, we'll just present
the arguments as a list instead. We could make an exception for Zed,
but I think I prefer having this be consistent across editors, and
the table format wasn't a requirement here.

Fixes #827

Signed-off-by: Anders Eknert <[email protected]>
@anderseknert anderseknert mentioned this issue Jun 12, 2024
Merged
anderseknert added a commit that referenced this issue Jun 13, 2024
@anderseknert
Fix markdown content rendering for Zed editor
018a6a2 
Since Zed doesn't render markdown tables yet, we'll just present
the arguments as a list instead. We could make an exception for Zed,
but I think I prefer having this be consistent across editors, and
the table format wasn't a requirement here.

Fixes #827

Signed-off-by: Anders Eknert <[email protected]>
anderseknert added a commit that referenced this issue Jun 13, 2024
@anderseknert
Fix markdown content rendering for Zed editor (#829)
e3e12a9 
Since Zed doesn't render markdown tables yet, we'll just present
the arguments as a list instead. We could make an exception for Zed,
but I think I prefer having this be consistent across editors, and
the table format wasn't a requirement here.

Fixes #827

Signed-off-by: Anders Eknert <[email protected]>
srenatus pushed a commit to srenatus/regal that referenced this issue Oct 1, 2024
@anderseknert @srenatus
Fix markdown content rendering for Zed editor (StyraInc#829)
df1cedf 
Since Zed doesn't render markdown tables yet, we'll just present
the arguments as a list instead. We could make an exception for Zed,
but I think I prefer having this be consistent across editors, and
the table format wasn't a requirement here.

Fixes StyraInc#827

Signed-off-by: Anders Eknert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working language server protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix markdown content rendering for Zed editor StyraInc/regal
1 participant
@anderseknert