Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: Clear old directories when renaming #1050

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

charlieegan3
Copy link
Member

This matches the behaviour of the fix cmd

This matches the behaviour of the fix cmd

Signed-off-by: Charlie Egan <[email protected]>
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test? :)

@charlieegan3 charlieegan3 merged commit 66a3a76 into StyraInc:main Sep 4, 2024
4 checks passed
@charlieegan3 charlieegan3 deleted the ls-clear-old-dirs branch September 4, 2024 13:13
@charlieegan3
Copy link
Member Author

The delete function is tested in the cli e2e test, but agree that it's not ideal...

srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
This matches the behaviour of the fix cmd

Signed-off-by: Charlie Egan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants