lsp: Make length check of inlay hints fatal #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the rest of the test is making use of the hints, we need to stop execution if the length check fails. Signed-off-by: Charlie Egan <[email protected]>
anderseknert
approved these changes
Sep 11, 2024
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <[email protected]>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Since the rest of the test is making use of the hints, we need to stop execution if the length check fails. Signed-off-by: Charlie Egan <[email protected]>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the rest of the test is making use of the hints, we need to stop execution if the length check fails.