Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive given arity mismatch in inconsistent-args #1252

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

anderseknert
Copy link
Member

While a mismatched arg is technically still a violation, the arity mismatch should probably be dealt with first, so let's have the compiler handle that.

Fixes #1250

Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

While a mismatched arg is technically still a violation, the arity mismatch should
probably be dealt with first, so let's have the compiler handle that.

Fixes #1250

Signed-off-by: Anders Eknert <[email protected]>
@anderseknert anderseknert merged commit 22ec7cb into main Nov 11, 2024
5 checks passed
@anderseknert anderseknert deleted the fix-inconsistent-args-arity-fp branch November 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent-args rule does not handle wildcard variables correctly
2 participants