No more "file" in locations! #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we now can exclude that: open-policy-agent/opa#6398 About a 10% reduction in eval time linting the Kics repo 🚀 We will still add a "file" attribute to locations reported in violations, but we'll source that from `input.regal.file.name` instead, and won't have to worry about `walk` traversing thousands of redundant nodes. Signed-off-by: Anders Eknert <[email protected]>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
As we now can exclude that: open-policy-agent/opa#6398 About a 10% reduction in eval time linting the Kics repo 🚀 We will still add a "file" attribute to locations reported in violations, but we'll source that from `input.regal.file.name` instead, and won't have to worry about `walk` traversing thousands of redundant nodes. Signed-off-by: Anders Eknert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we now can exclude that: open-policy-agent/opa#6398
About a 10% reduction in eval time linting the Kics repo 🚀
We will still add a "file" attribute to locations reported in violations, but we'll source that from
input.regal.file.nameinstead, and won't have to worry aboutwalktraversing thousands of redundant nodes.