Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: impossible-not #698

Merged
merged 1 commit into from
May 8, 2024
Merged

Rule: impossible-not #698

merged 1 commit into from
May 8, 2024

Conversation

anderseknert
Copy link
Member

See docs in PR (and issue) for further details.

Fixes #603

Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, really great that we can catch this one

@@ -0,0 +1,85 @@
# constant-condition
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# constant-condition
# impossible-not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Really ought to add the doc page as part of regal new to avoid this type of copy-paste mistakes..

See docs in PR (and issue) for further details.

Fixes #603

Signed-off-by: Anders Eknert <[email protected]>
@anderseknert anderseknert merged commit f4eb0f8 into main May 8, 2024
3 checks passed
@anderseknert anderseknert deleted the impossible-not branch May 8, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule: impossible-not
2 participants