Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use completion item kind table for completions icons #756

Merged
merged 1 commit into from
May 28, 2024
Merged

Use completion item kind table for completions icons #756

merged 1 commit into from
May 28, 2024

Conversation

anderseknert
Copy link
Member

Fixes #755

@anderseknert anderseknert force-pushed the completion-icons branch 2 times, most recently from 6eb5c42 to 43e6514 Compare May 28, 2024 08:10
charlieegan3
charlieegan3 approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@charlieegan3 charlieegan3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and much needed. Is there more we can do here to share with the outline icons? (even as a follow on PR)

@anderseknert
Copy link
Member Author

@charlieegan3 what do you mean with "share with the outline icons?" 🙂

@anderseknert anderseknert merged commit 372185b into main May 28, 2024
3 checks passed
@anderseknert anderseknert deleted the completion-icons branch May 28, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlieegan3 charlieegan3 charlieegan3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completions: incorrect icons used in completions popup
2 participants
@anderseknert @charlieegan3