lsp/completions: Implement better package items #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
commented
May 28, 2024
| @@ -701,7 +701,7 @@ func (l *LanguageServer) handleTextDocumentCompletion( | |||
| } | |||
|
|
|||
| return types.CompletionList{ | |||
| IsIncomplete: false, | |||
There was a problem hiding this comment.
This is a key part of the change here which has the client request completions on each char change. This allows the server to define the completions and filtering them.
|
This PR also has a fix for not showing completions on lines starting with \t etc. |
Items for packages will now be sorted by 'depth', show partial package refs where a package is comprised of many sub packages and continuously trigger completions in order to be able to provide up-to-date suggestions based on file changes. Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
anderseknert
force-pushed
the
better-packages
branch
from
453b99e
to
07be176
Compare
anderseknert
approved these changes
May 29, 2024
| @@ -701,7 +701,7 @@ func (l *LanguageServer) handleTextDocumentCompletion( | |||
| } | |||
|
|
|||
| return types.CompletionList{ | |||
| IsIncomplete: false, | |||
This was referenced May 29, 2024
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Items for packages will now be sorted by 'depth', show partial package refs where a package is comprised of many sub packages and continuously trigger completions in order to be able to provide up-to-date suggestions based on file changes. Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items for packages will now be sorted by 'depth',
show partial package refs where a package is comprised of many sub packages and continuously trigger completions in order to be able to provide up-to-date suggestions based on file changes.
Fixes #752
before
before.mov
after
Screen.Recording.2024-05-28.at.16.54.59.mov