Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add separate page for language server features #880

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

anderseknert
Copy link
Member

No description provided.

- [x] Formatting
- [x] Code completions
- [x] Code actions (quick fixes for linting issues)
- [x] [Diagnostics](https://github.com/StyraInc/regal/blob/main/docs/language-server.md#diagnostics) (linting)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the links here should be updated to point to docs.styra.com later... but since those aren't there yet, I'll do this in the meantime.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think of symbols more as that view in VS Code? Might that be good to show here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. will add!

Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

@@ -0,0 +1,137 @@
# Language Server

In order to support Rego policy development in editors like
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to support Rego policy development in editors like
To support Rego policy development in editors like

src="assets/lsp/diagnostics.png"
alt="Screenshot of diagnostics as displayed in Zed"/>

Future versions of Regal may include also compilation errors as part of diagnistics messages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a link to #745?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure! Fixing.

@anderseknert anderseknert merged commit 23c3bf5 into main Jul 1, 2024
3 checks passed
@anderseknert anderseknert deleted the lsp-docs branch July 1, 2024 12:23
srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants