lsp/hover: Show example links #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
commented
Jul 9, 2024
charlieegan3
commented
Jul 9, 2024
charlieegan3
commented
Jul 9, 2024
charlieegan3
force-pushed
the
hover-help
branch
2 times, most recently
from
c9d34e4
to
2becf0f
Compare
anderseknert
reviewed
Jul 9, 2024
|
I think I've addressed everything here, I'll aim to merge tomorrow. |
|
3a599f1 contains some fixes for head keywords. |
Where examples to https://docs.styra.com/opa/rego-by-example are available, then show the links to these pages. Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Results of benchmarking: old median 28.986063 old mean 99.36704471 new median 20.632625 new mean 84.75417271 new old 170.351834 165.913458 15.080667 18.174667 722.364416 14.838167 144.308166 40.304292 24.4045 22.223417 61.691458 548.937375 171.228291 349.011583 14.812834 19.470125 14.869208 18.471875 46.716167 78.956167 16.760459 15.528125 14.35275 15.014083 14.8865 35.748709 20.632625 48.546583 14.898875 25.510542 15.363084 70.541459 168.860167 17.247625 14.956 These results were tested by disabling all other keyword rule heads and measuring the total time to get the list of keywords in go. Signed-off-by: Charlie Egan <[email protected]>
This is to be used when a list of expressions is needed in rules and for keyword operations. Signed-off-by: Charlie Egan <[email protected]>
|
I'm merging this in order to allow others to test all the new stuff ahead of a release next week. |
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* lsp/hover: Show example links Where examples to https://docs.styra.com/opa/rego-by-example are available, then show the links to these pages. Signed-off-by: Charlie Egan <[email protected]> * Improve keyword performance Signed-off-by: Charlie Egan <[email protected]> * Remove comment Signed-off-by: Charlie Egan <[email protected]> * Tidy _determine_keywords for every Signed-off-by: Charlie Egan <[email protected]> * inst * Improve if keyword performance Results of benchmarking: old median 28.986063 old mean 99.36704471 new median 20.632625 new mean 84.75417271 new old 170.351834 165.913458 15.080667 18.174667 722.364416 14.838167 144.308166 40.304292 24.4045 22.223417 61.691458 548.937375 171.228291 349.011583 14.812834 19.470125 14.869208 18.471875 46.716167 78.956167 16.760459 15.528125 14.35275 15.014083 14.8865 35.748709 20.632625 48.546583 14.898875 25.510542 15.363084 70.541459 168.860167 17.247625 14.956 These results were tested by disabling all other keyword rule heads and measuring the total time to get the list of keywords in go. Signed-off-by: Charlie Egan <[email protected]> * Remove time stmt * Add exprs rule to ast package This is to be used when a list of expressions is needed in rules and for keyword operations. Signed-off-by: Charlie Egan <[email protected]> * Handle values in heads --------- Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where examples to https://docs.styra.com/opa/rego-by-example are available, then show the links to these pages.
Screen.Recording.2024-07-09.at.14.10.08.mov