rule: Fix pointless reassign issue when using with #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes StyraInc#904 I find the times to be comparable for the regal bundle + a simple violating file. ```sh regal $ go build && time ./regal lint . --disable-all --enable=pointless-r eassignment Rule: pointless-reassignment Description: Pointless reassignment of variable Category: style Location: thing.rego:10:6 Text: foo := e with foo as 2 Documentation: https://docs.styra.com/regal/rules/style/pointless-reassignment 201 files linted. 1 violation found in 1 file. real 0m1.906s user 0m6.344s sys 0m0.244s [3]regal $ bran Current: main Switched to branch 'pointless' Your branch is ahead of 'main' by 1 commit. (use "git push" to publish your local commits) regal $ go build && time ./regal lint . --disable-all --enable=pointless-reassignment 201 files linted. No violations found. real 0m1.580s user 0m2.930s sys 0m0.109s ``` Signed-off-by: Charlie Egan <[email protected]>
srenatus
approved these changes
Jul 9, 2024
|
Thanks Stephan |
|
Good catch! And a good fix. Thanks! 👏 |
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Fixes StyraInc#904 I find the times to be comparable for the regal bundle + a simple violating file. ```sh regal $ go build && time ./regal lint . --disable-all --enable=pointless-r eassignment Rule: pointless-reassignment Description: Pointless reassignment of variable Category: style Location: thing.rego:10:6 Text: foo := e with foo as 2 Documentation: https://docs.styra.com/regal/rules/style/pointless-reassignment 201 files linted. 1 violation found in 1 file. real 0m1.906s user 0m6.344s sys 0m0.244s [3]regal $ bran Current: main Switched to branch 'pointless' Your branch is ahead of 'main' by 1 commit. (use "git push" to publish your local commits) regal $ go build && time ./regal lint . --disable-all --enable=pointless-reassignment 201 files linted. No violations found. real 0m1.580s user 0m2.930s sys 0m0.109s ``` Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #904
I find the times to be comparable for the regal bundle + a simple violating file.