Include function args in ast.vars (and prefer-snake-case rule)
#947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
commented
Jul 29, 2024
| @@ -25,8 +25,8 @@ find_duplicates(arr) := {indices | | |||
|
|
|||
| # METADATA | |||
| # description: returns true if array has duplicates of item | |||
| has_duplicates(array, item) if count([x | | |||
| some x in array | |||
| has_duplicates(arr, item) if count([x | | |||
There was a problem hiding this comment.
Nice side effect of args counting as vars is how this now got flagged as shadowing the built-in array namespace.
anderseknert
force-pushed
the
include-args
branch
2 times, most recently
from
088d1d9
to
3fb68ae
Compare
| @@ -43,9 +56,26 @@ test_success_snake_cased_multiple_some_declaration if { | |||
| r == set() | |||
| } | |||
|
|
|||
| test_fail_camel_cased_function_argument if { | |||
There was a problem hiding this comment.
Do we want a _function_argument success case for completeness?
There was a problem hiding this comment.
Sure, I'll add one before merging 👍
charlieegan3
approved these changes
Jul 30, 2024
Also add end location to `prefer-snake-case` violations Fixes #942 Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
include-args
branch
from
3fb68ae
to
83d1132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #942