Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: Generate correct rule name when during Eval #975

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

charlieegan3
Copy link
Member

@charlieegan3 charlieegan3 commented Aug 8, 2024

Screen.Recording.2024-08-08.at.16.00.34.mov

This also notifies the client on errors:

Screen.Recording.2024-08-08.at.16.46.20.mov

@@ -485,6 +485,16 @@ func (l *LanguageServer) StartCommandWorker(ctx context.Context) {
if err != nil {
fmt.Fprintf(os.Stderr, "failed to evaluate workspace path: %v\n", err)

err := l.conn.Notify(ctx, "window/showMessage", types.ShowMessageParams{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@anderseknert anderseknert merged commit 4ba405e into StyraInc:main Aug 8, 2024
3 checks passed
@charlieegan3 charlieegan3 deleted the correct-rule-name-func branch August 8, 2024 16:22
srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants