Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: Implement bundle use in workspace Eval #987

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

charlieegan3
Copy link
Member

@charlieegan3 charlieegan3 commented Aug 14, 2024

This makes it possible to workspace eval rules based on data.

Screen.Recording.2024-08-14.at.16.47.34.mov

@charlieegan3 charlieegan3 changed the title Load bundles lsp: Implement bundle use in workspace Eval Aug 14, 2024
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome work!

internal/lsp/bundles/cache.go Outdated Show resolved Hide resolved
internal/lsp/bundles/cache.go Show resolved Hide resolved
internal/lsp/server.go Outdated Show resolved Hide resolved
This cache can be used to maintain a cache of bundles in memory that are
found in the workspace.

Signed-off-by: Charlie Egan <[email protected]>
@charlieegan3 charlieegan3 merged commit acbdb88 into StyraInc:main Aug 15, 2024
3 checks passed
@charlieegan3 charlieegan3 deleted the load-bundles branch August 15, 2024 10:30
srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
* WIP

* lsp/bundles: add a bundle cache

This cache can be used to maintain a cache of bundles in memory that are
found in the workspace.

Signed-off-by: Charlie Egan <[email protected]>

* lsp: Implement bundle use in workspace Eval

Signed-off-by: Charlie Egan <[email protected]>

* PR Feedback

---------

Signed-off-by: Charlie Egan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants