fix!: Address ModMessageSystem memory issue; No messages should be he…

…ld during game-time (#445)

No messages should be held during game-time

Nautilus/Utility/ModMessages/ModMessageSystem.cs

@@ -12,7 +12,7 @@ static ModMessageSystem()
         SaveUtils.RegisterOnStartLoadingEvent(OnStartLoading);
     }
 
-    private static bool _allowedToHoldGlobalMessages = true;
+    private static bool _allowedToHoldMessages = true;
 
     // address - inbox
     private static Dictionary<string, ModInbox> _inboxes = new Dictionary<string, ModInbox>();
@@ -47,14 +47,15 @@ public static void SendGlobal(string subject, params object[] contents)
         {
             globalMessage.TrySendMessageToInbox(inbox);
         }
-        if (_allowedToHoldGlobalMessages)
+        if (_allowedToHoldMessages)
         {
             _globalMessages.Add(globalMessage);
         }
     }
 
     /// <summary>
-    /// Sends a single message to a <see cref="ModInbox"/>. If the message is not read immediately, it will be held until read.
+    /// Sends a single message to a <see cref="ModInbox"/>. If the message is not read immediately, it will be held until read. Messages can not be held
+    /// during game-time.
     /// </summary>
     /// <param name="messageInstance">The message to send.</param>
     public static void Send(ModMessage messageInstance)
@@ -67,6 +68,9 @@ public static void Send(ModMessage messageInstance)
 
         // add to held messages instead:
 
+        if (!_allowedToHoldMessages)
+            return;
+
         if (!_heldMessages.TryGetValue(messageInstance.Recipient, out var heldMessageList))
             _heldMessages.Add(messageInstance.Recipient, new List<ModMessage>());
 
@@ -129,6 +133,7 @@ internal static void SendHeldMessagesToInbox(ModInbox inbox)
     private static void OnStartLoading()
     {
         _globalMessages.Clear();
-        _allowedToHoldGlobalMessages = false;
+        _heldMessages.Clear();
+        _allowedToHoldMessages = false;
     }
 }