-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newtonsoft patcher hotfix #244
Conversation
Fixes issue with newtonsoft patcher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is fine, I'm happy to move back to Finish()
for the QModPluginGenerator patcher if Initialize()
is causing issues. I haven't had a chance to test this and won't tonight, but I'm willing to trust Purple's testing for this and honestly, the change from Finish()
-> Initialize()
was never intended to stick around into the build. Mea culpa.
Should wait for @PrimeSonic to weigh in on versioning since there's been some discussion on that in the discord.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the consensus for versioning is as follows:
- When compiling internal, dev, or beta builds, bump the 4th version segment on each build
- When compiling public release builds, set the 4th version segment to zero and bump the rest accordingly
- Removing trailing
.0
segments from player facing version strings such as on Nexus or installer windows
Therefore, we should drop the .0
from the .iss here. Have made suggested changes in review comments so you can easily just commit them from here.
Hotfix to revert the timing change of the QModPluginGenerator that broke the Newtonsoft Patcher
Build.zip
QModManager_BZ.STABLE.zip
QModManager_SN.EXP.zip
QModManager_SN.STABLE.zip
QModManager_BZ.EXP.zip