Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check computeplans before running function #997

Merged
merged 9 commits into from
Sep 30, 2024
Merged

feat: check computeplans before running function #997

merged 9 commits into from
Sep 30, 2024

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Sep 6, 2024 •
edited
Loading

Description

Fixes FL-1659

Companion PR

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@linear Linear
Copy link

linear bot commented Sep 6, 2024

FL-1659 Cancellation of CP while building functions

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,frontend,camelyon

@Owlfred
Copy link

Owlfred commented Sep 6, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon,frontend: ✔️
  • Dispatch Jobs: ✔️
  • Documentation / doc: ✔️
  • MNIST / mnist,frontend: ✔️
  • SubstraFL / substrafl,frontend: ❌
  • SubstraSDK / sdk: ✔️

“It’s just a flesh wound.” ― The Black Knight, Monty Python and the Holy Grail

@guilhem-barthes guilhem-barthes force-pushed the feat/check-computeplans-before-running-function branch from 4506487 to 01a10ca Compare September 6, 2024 10:01
@github-actions github-actions bot added the api label Sep 9, 2024
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,doc,mnist,frontend,camelyon --refs substra-tests=feat/check-computeplans-before-running-function

@Owlfred
Copy link

Owlfred commented Sep 9, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

Nailed it!

@guilhem-barthes guilhem-barthes marked this pull request as ready for review September 10, 2024 09:42
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner September 10, 2024 09:42
@guilhem-barthes guilhem-barthes mentioned this pull request Sep 13, 2024
Merged
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk --refs substra-tests=feat/check-computeplans-before-running-function

@Owlfred
Copy link

Owlfred commented Sep 30, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“Rien ne sert de courir ; il faut partir à point.” ― Jean de La Fontaine (Le Lièvre et la Tortue)

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk --refs substra-tests=feat/check-computeplans-before-running-function

@Owlfred
Copy link

Owlfred commented Sep 30, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

SdgJlbl
SdgJlbl approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guilhem-barthes
feat: add image_builder.check_function_is_runnable
dd13740 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes
feat: add tests
629bd9e 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes
fix: add annotation to tests
78c4001 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes
feat: change order which check CP status
788d251 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes
feat: add Function.cancel()
c7d1186 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes
feat: add BuildCanceledError
808384f 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes
fix: use real uuid in test_check_function_is_runnable
55597e2 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes
fix: db call on test_check_function_is_runnable
d9bd9cd 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes
doc: change fragment
13a0cc5 
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes guilhem-barthes force-pushed the feat/check-computeplans-before-running-function branch from 0073706 to 13a0cc5 Compare September 30, 2024 14:59
@guilhem-barthes guilhem-barthes enabled auto-merge (squash) September 30, 2024 14:59
@guilhem-barthes guilhem-barthes merged commit 07d9311 into main Sep 30, 2024
7 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/check-computeplans-before-running-function branch September 30, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhem-barthes @Owlfred @SdgJlbl