Migrate FluentD Conf files to ConfigMap to make customizing FluentD conf simpler. #124
Conversation
daemonset/nonrbac/fluentd.yaml
Outdated
| @@ -38,6 +41,33 @@ spec: | |||
| readOnly: true | |||
| - name: pos-files | |||
| mountPath: /mnt/pos/ | |||
| - name: fluentd-sumologic-config | |||
There was a problem hiding this comment.
is there any reason not just mount whole directory other than individual files?
There was a problem hiding this comment.
Current Docker image seperates config across 2 directories. /fluentd/etc and fluentd/conf.d. So this was done this way to preserve and have a single configmap. Other options would be:
- 2 config maps for each directory, then just have 2 volumens and mounts.
- Change entrypoint script and keep all config in single dir
There was a problem hiding this comment.
Made changes to simplify this...
|
@frankreno How is this going to square with the Helm chart? Seems like this would effectively require duplicating the ConfigMap here and in the chart. I generally like the move. Would love to continue to make new sources more declarative/DRY. |
|
@bendrucker : sorry for the delay. We still need to get the release out however, we do need to square this away in there once we cut a new release. We still need to figure out the management to avoid 2 sets of config long term. |
Move FluentD configuration files to ConfigMap to make it easier to customize.