Skip to content
This repository has been archived by the owner on Feb 5, 2021. It is now read-only.

Add RBAC permissions #40

Merged
merged 3 commits into from
Sep 18, 2017
Merged

Add RBAC permissions #40

merged 3 commits into from
Sep 18, 2017

Conversation

AlexB138
Copy link
Contributor

Fixes: #39

@AlexB138
Copy link
Contributor Author

Does this need anything else, @stevezau @frankreno ?

@frankreno
Copy link
Contributor

@AlexB138 : First off thank you for the PR. This looks good. However, I am wondering if we should have 2 YAML files. One with RBAC, one without. That would be more in sync with a lot of the YAML files provided by k8s in their docs. Thoughts?

@AlexB138
Copy link
Contributor Author

AlexB138 commented Sep 16, 2017

Yeah, I've seen a couple of projects do that as well. I think the way to do it is to have them in separate directories. I say this because doing kubectl apply -f <directory> is a common workflow for provisioning and having two yaml files in the same directory with different configs for the same resources would break that pattern.

I'll update the PR to have /daemonset/rbac/fluentd.yaml and daemonset/nonrbac/fluentd.yaml, if that works for you.

@frankreno
Copy link
Contributor

That sounds great.

@AlexB138
Copy link
Contributor Author

@frankreno Alright, broken out as discussed and updated the README!

@moos3
Copy link

moos3 commented Sep 18, 2017

👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍

I just had to figure this stuff out on my own. Please merge in!

@frankreno frankreno merged commit 95c6325 into SumoLogic:master Sep 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants