This repository has been archived by the owner on Feb 5, 2021. It is now read-only.
Add labels to k8s_metadata #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@suversky this is a great add, love it. Can you please add some details to the readme on this? Having a dedicated section at the bottom that explains this is fine by me but lets add that as well. |
|
LGTM, thanks! |
|
I will cut a new release in a few days after I work thru the current open issues and address any issues there, will update here once I do. |
frankreno
added a commit
that referenced
this pull request
Oct 5, 2018
- [Add labels to k8s_metadata](#83) - [Add source_host to conf.d/systemd/source.containers.conf](#84) - minor refactoring and testing - upgrade fluent-plugin-sumologic_output to latest (1.3.1) - expose additional configuration options to provide more control over fluent-plugin-kubernetes_metadata_filter using default values (fixes #80 and #35)
|
@suversky |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR allows users to specify labels as format strings, e.g.:
SOURCE_NAME="%{label:app}:%{label:version}"Technical details
kubernetes[:labels][:foo]is flattened tok8s_metadata[:"label:foo"]because the%format operator does not allow nested hash lookup - i.e. there is no way to do the following:k8s_metadatasets a defaultundefinedvalue because unlikenamespace,pod,containerandsource_host, labels are not guaranteed to exist. In theSOURCE_NAMEexample above, if we have anapp: foolabel but noversionlabel, then we will getfoo:undefinedas a source name instead of the more mysteriousfoo:.