test(integration): run etcd in memory for kind #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This didn't seem to make the tests faster, but maybe it'll make them more robust? We've had some etcd timeouts recently. |
|
tests are failing 🙈 |
swiatekm
force-pushed
the
test/integration/inmemoryetcd
branch
from
446b8f3
to
9f077a7
Compare
Not anymore. But I think this is still a good change, even if tests needed a different fix. |
andrzej-stencel
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Etcd apparently does a lot of I/O on its storage, and this can be an issue in environments with slow disks, like CI runners. Put the storage in-memory instead.
This didn't really improve performance in testing, but I've recently seen some CI jobs fail due to etcd timing out, and I have hope that this will help.
See also: kubernetes-sigs/kind#845