Skip to content

Commit

Permalink
Restrict shapely dependency to <2 (#130)
Browse files Browse the repository at this point in the history
  • Loading branch information
kandersolar authored Jan 11, 2022
1 parent 213d050 commit 91c7657
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 9 deletions.
6 changes: 5 additions & 1 deletion docs/sphinx/whatsnew/v1.5.2.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,14 @@
v1.5.2 (DATE XX, 2021)
======================

Enhancements
Requirements
------------

* Add python 3.9 to test configuration (:ghpull:`122`)
* Set the upper bound on shapely to version 2.0 (not yet released).
The shapely dependency may be dropped
altogether in a future pvfactors release. (:ghpull:`130`)


Fixes
-----
Expand Down
14 changes: 7 additions & 7 deletions pvfactors/tests/test_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -652,21 +652,21 @@ def test_engine_w_faoi_fn_in_irradiance_vfcalcs(params, pvmodule_canadian):
# Run timestep
pvarray = eng.run_full_mode(fn_build_report=lambda pvarray: pvarray)
# Checks
np.testing.assert_almost_equal(
np.testing.assert_allclose(
pvarray.ts_pvrows[0].front.get_param_weighted('qinc'),
1110.1164773159298)
np.testing.assert_almost_equal(
np.testing.assert_allclose(
pvarray.ts_pvrows[1].front.get_param_weighted('qinc'), 1110.595903991)
np.testing.assert_almost_equal(
np.testing.assert_allclose(
pvarray.ts_pvrows[2].front.get_param_weighted('qinc'), 1112.37717553)
np.testing.assert_almost_equal(
np.testing.assert_allclose(
pvarray.ts_pvrows[1].back.get_param_weighted('qinc'),
116.49050349491208)
# Check absorbed irradiance: calculated using faoi functions
np.testing.assert_almost_equal(
np.testing.assert_allclose(
pvarray.ts_pvrows[2].front.get_param_weighted('qabs'),
[1109.1180884])
np.testing.assert_almost_equal(
[1109.1180884], rtol=1e-6)
np.testing.assert_allclose(
pvarray.ts_pvrows[1].back.get_param_weighted('qabs'),
[114.2143503])

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pvlib>=0.9.0,<0.10.0
shapely>=1.6.4.post2
shapely>=1.6.4.post2,<2
matplotlib
future
six

0 comments on commit 91c7657

Please sign in to comment.