Dashboard widget for Traffic Totals - fix license #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbgarga
reviewed
Dec 7, 2016
| * 5. Products derived from this software may not be called "pfSense" | ||
| * nor may "pfSense" appear in their names without prior written | ||
| * permission of the Electric Sheep Fencing, LLC. | ||
| * originally part of m0n0wall (http://m0n0.ch/wall) |
There was a problem hiding this comment.
Was this file originally part of m0n0wall?
| * 5. Products derived from this software may not be called "pfSense" | ||
| * nor may "pfSense" appear in their names without prior written | ||
| * permission of the Electric Sheep Fencing, LLC. | ||
| * originally part of m0n0wall (http://m0n0.ch/wall) |
There was a problem hiding this comment.
Was this file originally part of m0n0wall?
There was a problem hiding this comment.
@rbgarga - No, of course not, but the license is copied from your recent mass commit to this very same package... You might want to review all the packages and redo this in one batch again. I noticed some files still have BSD (the two-clause variant) license as well.
Edit: Indeed, checked and pretty much any XML package file I have on 2.3.3 has BSD 2-clause license.
$ find /usr/local -type f -name \*.xml | xargs grep "POSSIBILITY OF SUCH DAMAGE" | wc -l
53
Even core pfSense things like the XML in /usr/local/www/wizards/ have BSD/ESF license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix license for pfsense#168
@SunStroke74 - kindly merge