Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Products filter labels #158

Closed
wants to merge 27 commits into from
Closed

Products filter labels #158

wants to merge 27 commits into from

Conversation

MikeSaburov
Copy link
Contributor

@MikeSaburov MikeSaburov commented Apr 17, 2024 •
edited by anksuunamun
Loading

Completed the test task as described

@anksuunamun anksuunamun self-requested a review April 18, 2024 15:20
@anksuunamun
Copy link
Contributor

anksuunamun commented Apr 22, 2024 •
edited
Loading

Task description:

  1. Реализовать компонент ProductsFilterLabels, который принимает массив описаний лейблов фильтров (например, это объекты со свойствами name, id, label; сам массив - например, filterAttributes) и на основе этого рисует черные лейблы. Лейблы должны поддерживать событие нажатия на крестик и передавать пользователю компонента информацию о своих name и id.

  2. Также внутри компонента перед лейблами разместить кнопку "By default", которая передает пользователю компонента инфу о том, что её нажали.

  3. Постараться дробить компоненты, используемые внутри ProductsFilterLabels на небольшие понятные компоненты. Сам компонент разместить в src/components/Product. Относящиеся только к нему кусочки кода располагать в его папке.

Макет - https://www.figma.com/file/8BD1H4T6LjsTP7EVBeEJ24/Coffee-shop?type=design&node-id=2413-4945&mode=design&t=gdKdBfvRIx1xk2AU-0

скрин, чтобы знать что искать на макете:

репо проекта: https://github.com/Sunagatov/Iced-Latte-Frontend

image

@anksuunamun
Copy link
Contributor

Completed the test task as described

  • implemented badges/labels for illustrating product filtering (src/components/Product/ProductsFilterLabels/ProductsFilterLabels.tsx)
  • new component added on products page

iakivpekarskyi
iakivpekarskyi previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@iakivpekarskyi iakivpekarskyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Lightness322
Lightness322 previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@Lightness322 Lightness322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

freecree
freecree previously approved these changes Apr 22, 2024
View reviewed changes
@anksuunamun
fix: fix sonar issues
f84c21b
@anksuunamun
Merge branch 'development' into ProductsFilterLabels
bb9da30 
# Conflicts:
#	src/components/Review/CommentsList/CommentsList.tsx
#	src/components/Review/ReviewComponent/ReviewComponent.tsx
#	src/components/UI/Dropdown/Dropdown.tsx
#	src/services/reviewService.ts
#	src/types/Button.ts
@anksuunamun
Merge branch 'development' into ProductsFilterLabels
ead419b 
# Conflicts:
#	src/components/Review/CommentsList/CommentsList.tsx
#	src/components/Review/ReviewComponent/ReviewComponent.tsx
#	src/components/UI/Dropdown/Dropdown.tsx
#	src/services/reviewService.ts
#	src/types/Button.ts
@anksuunamun
Merge branch 'development' into ProductsFilterLabels
5e55188 
# Conflicts:
#	src/components/Review/CommentsList/CommentsList.tsx
#	src/components/Review/ReviewComponent/ReviewComponent.tsx
#	src/components/UI/Dropdown/Dropdown.tsx
#	src/services/reviewService.ts
#	src/types/Button.ts
@anksuunamun
fix: fix indents
d513182
@anksuunamun
refactor: refactor comment
c9f8be4
@anksuunamun
refactor: refactor comment
d74a525
@anksuunamun
refactor: refactor comment
f59896a
@anksuunamun
refactor: refactor comment
e2697a4
@anksuunamun
fix: undo changes in jest.config.js
c5c1f9b
@anksuunamun
refactor: return handleError in ReviewComponent.tsx
e1c5cfe
@anksuunamun anksuunamun mentioned this pull request Apr 22, 2024
Merged
@anksuunamun
Copy link
Contributor

These changes will be merged into PR #169, because the forked repository was causing issues with Sonar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anksuunamun anksuunamun anksuunamun left review comments

@freecree freecree freecree left review comments

@iakivpekarskyi iakivpekarskyi iakivpekarskyi left review comments

@Lightness322 Lightness322 Lightness322 left review comments

@Sunagatov Sunagatov Awaiting requested review from Sunagatov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MikeSaburov @anksuunamun @freecree @iakivpekarskyi @Lightness322