Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request 52 (ReducedFullSampler) updated #1064

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Pull request 52 (ReducedFullSampler) updated #1064

wants to merge 4 commits into from

Commits on Feb 29, 2024

  1. ADD: Added the ReducedFullSampler for more efficient full sampling in… 

    … groupwise registration.
    @N-Dekker
    Mathias Polfliet authored and N-Dekker committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f6cd3c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. STYLE: Run clang-format on ReducedFullSampler 

    This is necessary in order to make the CI at github.com/SuperElastix/elastix happy.
    @N-Dekker
    N-Dekker committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    fa53d0c View commit details
    Browse the repository at this point in the history

  2. COMP: Make ReducedFullSampler compilable on current git main revision 

    This work was originally "based" on commit 2ec22d0 "VER: increased to 4.900 in preparation of release", 2018-03-19. The code is adjusted to make it compile on the latest revision of the main branch:

- IsInside is replaced with IsInsideInWorldSpace
- Obsolete typedefs inherited from Superclass2 were removed
- An elxOverrideGetSelfMacro call is added
    @N-Dekker
    N-Dekker committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    fcb7393 View commit details
    Browse the repository at this point in the history

  3. COMP: Fix -Winconsistent-missing-override warnings in ReducedFullSampler 

    Fixed macos-12/clang warnings like:
> warning: 'SelectNewSamplesOnUpdate' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

From https://my.cdash.org/viewBuildError.php?type=1&buildid=2507427
    @N-Dekker
    N-Dekker committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    dd9cfd4 View commit details
    Browse the repository at this point in the history