Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Use vcpkg to get ITK #161

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

WIP: Use vcpkg to get ITK #161

wants to merge 8 commits into from

Commits on Sep 17, 2020

  1. WIP: Use vcpkg to get ITK 

    See also https://discourse.itk.org/t/how-to-avoid-rebuilding-itk-by-azure-ci-at-the-github-of-another-project-elastix/2002
    @N-Dekker
    N-Dekker committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    bdcd826 View commit details
    Browse the repository at this point in the history

  2. COMP: CI now does git pull vcpkg and bootstrap-vcpkg 

    Hoping to fix:

> LINK : fatal error LNK1181: cannot open input file '\lib\double-conversion.lib'

Dženan Zukić @dzenanz informed us that there was some work regarding ITK_USE_SYSTEM_DOUBLECONVERSION between IK 5.0.0 and 5.0.1, which might solve this problem.
    @N-Dekker
    N-Dekker committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    8ed6103 View commit details
    Browse the repository at this point in the history

  3. COMP: Add vcpkg integrate install 

    Suggested by Dženan Zukić @dzenanz
    @N-Dekker
    N-Dekker committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    35d0f0f View commit details
    Browse the repository at this point in the history

  4. COMP: Fix link errors building double-conversion from vcpkg 

    Fixed by ugly `link_directories` quick-fix.
See also #161 (comment)
    @N-Dekker
    N-Dekker committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    418901e View commit details
    Browse the repository at this point in the history

  5. COMP: Build elastix by MSBuild, instead of CMake --build 

    Yet another attempt to fix those link errors
    @N-Dekker
    N-Dekker committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    5322924 View commit details
    Browse the repository at this point in the history

  6. COMP: Add msbuildArguments: /p:VcpkgEnabled=true 

    Suggested at "Disable automatic integration for a particuar VS project"
microsoft/vcpkg#281
    @N-Dekker
    N-Dekker committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    1dc914a View commit details
    Browse the repository at this point in the history

  7. COMP: Remove quickfix for double-conversion.lib 

    Check if it still compiles with VcpkgEnabled=true
    @N-Dekker
    N-Dekker committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    bf2ab3b View commit details
    Browse the repository at this point in the history

  8. COMP: Temporarily loosen ITK requirement from version 5.1.1 to 5.1 

    Work around the CMake Error at
https://dev.azure.com/kaspermarstal/Elastix/_build/results?buildId=971&view=logs&j=8113fa60-6c65-540e-d189-4caa7b0fea60&t=ec6f6503-6d4b-5e80-e979-365ac800d840

> CMake Error at C:/vcpkg/scripts/buildsystems/vcpkg.cmake:493 (_find_package):
>  Could not find a configuration file for package "ITK" that is compatible
>  with requested version "5.1.1".
>
> The following configuration files were considered but not accepted:
>
> C:/vcpkg/installed/x64-windows/share/itk/ITKConfig.cmake, version: 5.1.0
    @N-Dekker
    N-Dekker committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    0a6ab68 View commit details
    Browse the repository at this point in the history