Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust iceslick textures #1105

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Conversation

HybridDog
Copy link
Contributor

@HybridDog HybridDog commented May 22, 2019

Before:
before

After (Changed iceslick):
2019-05-23-115645_1920x1080_scrot
2019-05-23-115652_1920x1080_scrot

Edit: removed the ice bridge changes images

@weluvgoatz
Copy link
Member

I prefer the old ones, these ones are too white in my opinion. The idea with making them brighter is nice, but it really needs to be more blue.

@qwertychouskie
Copy link
Contributor

What would it look like with the new iceslick but the old icebridge?

@Alzter
Copy link
Member

Alzter commented May 23, 2019

I think it'd be a cool detail to add some icy frosting on top of the bridge, but maybe that would get confused with slippery ice so I'm not sure.

@HybridDog
Copy link
Contributor Author

HybridDog commented May 23, 2019

What would it look like with the new iceslick but the old icebridge?

2019-05-23-115645_1920x1080_scrot
2019-05-23-115652_1920x1080_scrot

I think it'd be a cool detail to add some icy frosting on top of the bridge, but maybe that would get confused with slippery ice so I'm not sure.

You could also make new, similar-looking tiles for the icy bridge because the current ones are as far as I can see just like a blue version of the common brown blocks.

@tobbi
Copy link
Member

tobbi commented Aug 27, 2019

Could we have both variants?

@weluvgoatz
Copy link
Member

weluvgoatz commented Aug 27, 2019 via email

@HybridDog
Copy link
Contributor Author

HybridDog commented Aug 28, 2019

In a frozen water puddle, the ice usually looks white and not blue.
img
The iceslick represents a frozen puddle (as far as I can see), but the other textures also constitute a place with frozen water.
How do you think about the white iceslick?

Could we have both variants?

I personally would prefer new textures over reusing old ones with new colour and/or contrast.
For example, that one: https://opengameart.org/content/hand-painted-texture-iceberg

@weluvgoatz weluvgoatz added the status:needs-work In progress, but no one is currently working on it (New volunteers welcome) label Jan 2, 2020
@busybody42

This comment was marked as off-topic.

@tobbi
Copy link
Member

tobbi commented Jul 12, 2020

@HybridDog or @SuperTux/graphics-designers Would you mind assigning new tile IDs to those new textures? Then we can get this merged :)

@weluvgoatz
Copy link
Member

The images would need to be renamed as well.

@Rusty-Box
Copy link
Member

I think the ice bridge tiles are too white. A more bluish tint is prefered since the ice bridge on the worldmap is blue as well. Having both is pointless. The ice slick i don't mind.

@weluvgoatz
Copy link
Member

The iceslick looks well enough, but I agree this icebridge is really bad.

I have increased the brightness and contrast, and reduced the saturation.

[ci skip]
@HybridDog HybridDog changed the title Adjust icebridge and iceslick textures Adjust iceslick textures Jul 13, 2020
@HybridDog
Copy link
Contributor Author

I have removed the icebridge change.

@Rusty-Box
Copy link
Member

Thanks. Everything seem good to go. Does anyone else want to say something about it, before merging?

@Zwatotem Zwatotem merged commit 96c3ea5 into SuperTux:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:design status:needs-work In progress, but no one is currently working on it (New volunteers welcome)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants