Add swimming

[weluvgoatz]

Here is the revived branch of swimming, which is a planned feature. The code and sprites were created mainly by @Zwatotem and me. Although I have tested and fixed numerous bugs with this feature, it would be nice if anyone can find any that I missed and maybe then this could be merged? Swimming would fit right in the game anyway.

[Ordoviz]

Is it intentional that you can spam the jump button to gain hyper speed? I suggest limiting Tux’ speed.

Issues:

General:

• Hold up while you are in water. Eventually, Tux will rotate on the water surface.
• When Tux jumps into water from above, the sprite flips out for a frame. This makes the transition not very smooth.

Big Tux:

• Big Tux teleports a little when his hitbox changes from horizontally to vertically and vice versa.
• Big Tux can buttjump when he makes a high jump out of the water. This looks really odd.

Fire/ice flower:

• The bullets get shot to the right or left not the direction Tux is facing. We also need to discuss how Tux creates these bullets and how he throws them (with the right movement it looks like Tux poops them out).

Small Tux:

• When small Tux jumps out of the water to the top left, he flips after he reaches his max height and falls down on his back. This is nice for falling straight down but not for jumping in a parabola (it does not happen with big Tux or when jumping to the top right)

Missing/bad graphics:

• Big Tux looks very janky. I cannot take him seriously.
• Create a sound effect that plays when pressing JUMP while in water and make Tux swirl his arms. Some water bubbles would also be nice.

Edit: I almost forget: Thank you for the great work! Swimming and sliding is exactly what SuperTux needs and what makes the game fun.

[Narre]

I've been working on a new add-on for SuperTux for a while now (a.k.a since 2015), and I have a good few levels centred around swimming, so I will test this feature in actual levels (rather than test levels) as soon as I can, and I will make sure to leave as much feedback as I can.

[christ2go]

I hope, these comments might help making the pr even better. I didn't test it yet, so this is mostly code-style/code-organization related.

[weluvgoatz]

I've fixed some bugs with this PR. I marked them off that checklist, as well as some suggestions that aren't necessary for this PR to be merged/things I can't replicate or reproduce or see as a problem.

[Ordoviz]

Your new changes removed Tux’ backflip animation.

[weluvgoatz]

Tux is planned to have a new backflip animation eventually anyway that isn't rotated.

…

On Fri, May 29, 2020, 9:38 PM Lennard Hofmann ***@***.***> wrote: Your new changes removed Tux’ backflip animation. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1407 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJPWEMVQRZL2F64OIZO7N23RUCEWDANCNFSM4NIX2U5A> .

[Grumbel]

What's the plan with the backflip? I kind of liked the old behavior and haven't really seen much reason to change it.

[weluvgoatz]

@Grumbel: At some point, the backflip will be redrawn to look better, as the rotating behavior definitely has room for improvement (a hand drawn flipping animation is ideal) (would be part of the Tux graphics revamp, see #1110 for more). However, if a stable release happens before the graphics are updated, then the old behavior will probably be temporarily re-added.