Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background ".sprite" support #2748

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

Vankata453
Copy link
Member

Backgrounds can now load ".sprite" files for top, middle and bottom images. The current action for any or all of those images can be set via scripting.

Backgrounds are not animated in the editor to prevent inconvenience.

Closes #1089.

Backgrounds can now load ".sprite" files for top, middle and bottom images. The current action for any or all of those images can be set via scripting.

Backgrounds are not animated in the editor to prevent inconvenience.

Closes SuperTux#1089.
@mrkubax10 mrkubax10 requested a review from tobbi January 30, 2024 18:52
src/object/background.cpp Outdated Show resolved Hide resolved
@tobbi
Copy link
Member

tobbi commented May 18, 2024

Can you rebase this and mark the method static or whatever?

@Vankata453 Vankata453 requested a review from tobbi May 20, 2024 14:26
src/object/background.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Frostwithasideofsalt Frostwithasideofsalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
works

Copy link
Member

@weluvgoatz weluvgoatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me but let's still wait for Tobbi's requests to be addressed.

Copy link
Member

@MatusGuy MatusGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Will test pretty soon.

src/object/background.cpp Show resolved Hide resolved
src/object/background.cpp Outdated Show resolved Hide resolved
MatusGuy

This comment was marked as off-topic.

@MatusGuy MatusGuy dismissed their stale review July 30, 2024 13:56

oopsy poopsy

Copy link
Member

@MatusGuy MatusGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine. Just change the name of that function and I'll approve this.

@Vankata453 Vankata453 merged commit 1fbfd10 into SuperTux:master Jul 31, 2024
33 checks passed
@Vankata453 Vankata453 deleted the background-sprite-support branch July 31, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow us to set .sprite files as backgrounds
6 participants