-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background ".sprite" support #2748
Background ".sprite" support #2748
Conversation
Backgrounds can now load ".sprite" files for top, middle and bottom images. The current action for any or all of those images can be set via scripting. Backgrounds are not animated in the editor to prevent inconvenience. Closes SuperTux#1089.
Can you rebase this and mark the method static or whatever? |
7cf2cc2
to
bc40214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me but let's still wait for Tobbi's requests to be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Will test pretty soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine. Just change the name of that function and I'll approve this.
Backgrounds can now load ".sprite" files for top, middle and bottom images. The current action for any or all of those images can be set via scripting.
Backgrounds are not animated in the editor to prevent inconvenience.
Closes #1089.