Reloading resources from "Debug" menu #2928

Vankata453 · 2024-04-28T21:12:17Z

The new "Reload Resources" option in the "Debug" menu allows for reloading all fonts, textures, sprites and tilesets.

Additionally:

Removes the name field for sprites. I honestly didn't know it existed before, and don't know what the point of it is, considering it's not referenced anywhere in the code, other than in logs, where a filename can be used instead.

Closes #2901.

Frostwithasideofsalt

Thank the gato gods 🙏🏼

src/supertux/tile_set.cpp

src/video/sdl_surface_ptr.hpp

tylerandari13 · 2024-05-16T06:06:58Z

My train of thought to test this was to load the game, and remove an image. If it works then it should display a missing texture, because the images are no longer there, which resulted in this:

[WARNING] /home/tylerandari12/STcompilation/supertux/src/video/texture_manager.cpp:84 Image '/res/industrial/gfx-enemy/duker/duker-body.png' doesn't exist. Attempting to load ".deprecated" version.
[WARNING] /home/tylerandari12/STcompilation/supertux/src/video/texture_manager.cpp:439 Couldn't load texture '/res/industrial/gfx-enemy/duker/duker-body.png' (now using dummy texture): Couldn't open '/res/industrial/gfx-enemy/duker/duker-body.deprecated.png': not found
[WARNING] /home/tylerandari12/STcompilation/supertux/src/video/texture_manager.cpp:84 Image '/res/industrial/gfx-enemy/duker/duker-end.png' doesn't exist. Attempting to load ".deprecated" version.
[WARNING] /home/tylerandari12/STcompilation/supertux/src/video/texture_manager.cpp:439 Couldn't load texture '/res/industrial/gfx-enemy/duker/duker-end.png' (now using dummy texture): Couldn't open '/res/industrial/gfx-enemy/duker/duker-end.deprecated.png': not found
[WARNING] /home/tylerandari12/STcompilation/supertux/src/video/texture_manager.cpp:84 Image '/res/industrial/gfx-enemy/duker/duker-head.png' doesn't exist. Attempting to load ".deprecated" version.
[WARNING] /home/tylerandari12/STcompilation/supertux/src/video/texture_manager.cpp:439 Couldn't load texture '/res/industrial/gfx-enemy/duker/duker-head.png' (now using dummy texture): Couldn't open '/res/industrial/gfx-enemy/duker/duker-head.deprecated.png': not found
[WARNING] /home/tylerandari12/STcompilation/supertux/src/video/texture_manager.cpp:84 Image '/res/industrial/gfx-enemy/duker/duker-head.png' doesn't exist. Attempting to load ".deprecated" version.
[WARNING] /home/tylerandari12/STcompilation/supertux/src/video/texture_manager.cpp:376 Couldn't load texture '/res/industrial/gfx-enemy/duker/duker-head.png' (now using dummy texture): Couldn't open '/res/industrial/gfx-enemy/duker/duker-head.deprecated.png': not found
[FATAL] /home/tylerandari12/STcompilation/supertux/src/supertux/main.cpp:745 Unexpected exception: Cannot load image.

(The game closed after this was printed.)

duker-body.png, duker-end.png, and duker-head.png are the three images I removed so i could test. duker-head.png was the only image on a scripted object. Im not sure why the other two also tried to load.

I found another thing, which Im not sure if its related directly to this PR, but I might as well mention it. When this happened I thought "Well that sucks, but if I open the game again I should be able to add the images back in after opening and hit reload resources to make them appear.", but when I opened the level again, the scripted object which had the image was not there at all. I closed the game, added the images back in, and reopened the level, and the scripted object was back again.

Vankata453 · 2024-05-16T06:54:26Z

duker-body.png, duker-end.png, and duker-head.png are the three images I removed so i could test. duker-head.png was the only image on a scripted object. Im not sure why the other two also tried to load.

It reloads everything loaded since the start of the game.

I found another thing, which Im not sure if its related directly to this PR, but I might as well mention it. When this happened I thought "Well that sucks, but if I open the game again I should be able to add the images back in after opening and hit reload resources to make them appear.", but when I opened the level again, the scripted object which had the image was not there at all. I closed the game, added the images back in, and reopened the level, and the scripted object was back again.

Doesn't matter where the script object is, the resource is loaded into the game separately in its own manager.

MatusGuy · 2024-07-08T12:16:24Z

src/supertux/menu/debug_menu.cpp

+      SpriteManager::current()->reload();
+      TileManager::current()->reload();
+    })
+    .set_help(_("Reloads all fonts, textures, sprites and tilesets."));


The fonts don't reload.

Resources::load()

MatusGuy

Fonts don't reload, but because most modders don't care about changing the fonts, this should be good to go.

Vankata453 · 2024-08-06T05:52:58Z

It's not, because it's supposed to do that too. Will look into it.

Vankata453 · 2024-08-07T11:25:58Z

TTF fonts now properly reload.

[ci skip]

Vankata453 added 5 commits April 28, 2024 20:46

Sprite reloading

6d983c0

Tileset reloading

827fab9

Texture reloading

11cef20

"Reload Resources" button in "Debug" menu

b9e2159

Destroy old textures on reload

218b6e8

Frostwithasideofsalt approved these changes Apr 30, 2024

View reviewed changes

mrkubax10 added type:feature category:code status:needs-review Work needs to be reviewed by other people labels Apr 30, 2024

tobbi reviewed May 6, 2024

View reviewed changes

src/supertux/tile_set.cpp Outdated Show resolved Hide resolved

tobbi reviewed May 6, 2024

View reviewed changes

src/video/sdl_surface_ptr.hpp Show resolved Hide resolved

Add comment and newline [ci skip]

3bb35a1

tobbi approved these changes May 7, 2024

View reviewed changes

tylerandari13 mentioned this pull request May 20, 2024

Objects with missing sprite do not load at all. #2946

Open

6 tasks

MatusGuy reviewed Jul 8, 2024

View reviewed changes

Merge branch 'master' into reload-resources

0fb68f7

MatusGuy approved these changes Aug 5, 2024

View reviewed changes

Fonts now properly reload

5c236f2

Move TTFSurfaceManager::clear_cache() call to Resources::load()

1dcf71b

[ci skip]

MatusGuy approved these changes Aug 29, 2024

View reviewed changes

Vankata453 merged commit 2379967 into SuperTux:master Oct 24, 2024

Vankata453 deleted the reload-resources branch October 24, 2024 17:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reloading resources from "Debug" menu #2928

Reloading resources from "Debug" menu #2928

Vankata453 commented Apr 28, 2024 •

edited

Loading

Frostwithasideofsalt left a comment

tylerandari13 commented May 16, 2024

Vankata453 commented May 16, 2024 •

edited

Loading

MatusGuy Jul 8, 2024

Vankata453 Jul 8, 2024 •

edited

Loading

MatusGuy left a comment •

edited

Loading

Vankata453 commented Aug 6, 2024

Vankata453 commented Aug 7, 2024

Reloading resources from "Debug" menu #2928

Reloading resources from "Debug" menu #2928

Conversation

Vankata453 commented Apr 28, 2024 • edited Loading

Frostwithasideofsalt left a comment

Choose a reason for hiding this comment

tylerandari13 commented May 16, 2024

Vankata453 commented May 16, 2024 • edited Loading

MatusGuy Jul 8, 2024

Choose a reason for hiding this comment

Vankata453 Jul 8, 2024 • edited Loading

Choose a reason for hiding this comment

MatusGuy left a comment • edited Loading

Choose a reason for hiding this comment

Vankata453 commented Aug 6, 2024

Vankata453 commented Aug 7, 2024

Vankata453 commented Apr 28, 2024 •

edited

Loading

Vankata453 commented May 16, 2024 •

edited

Loading

Vankata453 Jul 8, 2024 •

edited

Loading

MatusGuy left a comment •

edited

Loading